Not to sound process heavy, but through experience and best practicies we have landed on some flow to how changes happen to lightblue related projectcs. This document intends to capture that to make it clear how thinks should work.
NOTE: this is NOT set in stone! This is expected to change over time as better ways are developed and agreed on. If you disagree with this document it's a great topic for discussion on the developer forum!
There is one board setup on waffle.io to bring all issues into a single kanban board:
The flow of issues through each board is the same.
Issues not ready for any action can be discussed on the developer forum, user forum, or opened directly as issues in the appropriate github repository. Once an issue is opened the general flow is outlined below.
Prepare Issue for Work
These steps are done by contributors in general.
- Issue goes to "Backlog" column on waffle.io.
- Someone assigns a milestone. [optional]
- Issue is moved to "Ready" column when description is sufficient for work to begin.
Fix the Issue
Someone decides to work on the issue and:
- Assigns the issue to themself.
- Move issue to "In Progress" column.
- Creates a fork of the master branch in their own user account on github.
- Develop change in the fork.
- Issue a pull request (PR) when work is complete.
- The PR should reference the original issue(s) being fixed.
- Ideally reference the issues being fixed in the subject of the PR so that waffle.io knows to link the PR to the issue.
- The PR (and linked issue) are put in the "Ready For Review" column.
- Someone other than the creator of the pull request reviews the pull request.
- Blocking issues are noted in comments of the pull request.
- Non-blocking issues are opened as new issues in the repo.
- If there are blocking issues:
- The original author fixes the issue and makes comments about resolution on the pull request.
- The fixes are reviewed, if good continue, else repeat this section.
- If review is good (no issues, clean merge, travis-ci build successful):
- The pull request is merged.
- If the original issue was not linked to the PR and therefore not auto-closed, the original issue should be closed manually.